Support to customize the attributes to expose for Spark engine #4541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turboFei
changed the title
3 tasks
turboFei
force-pushed
the
expose
branch
2 times, most recently
from
b10f4e2
to
7666826
Compare
pan3793
reviewed
Mar 16, 2023
kyuubi-common/src/main/scala/org/apache/kyuubi/config/KyuubiConf.scala
Outdated
Show resolved
Hide resolved
pan3793
approved these changes
Mar 16, 2023
zwangsheng
approved these changes
Mar 16, 2023
|
cc @cxzl25 as well, since you were done similar things |
Codecov Report
@@ Coverage Diff @@
## master #4541 +/- ##
============================================
+ Coverage 53.32% 53.33% +0.01%
Complexity 13 13
============================================
Files 572 572
Lines 31392 31399 +7
Branches 4228 4226 -2
============================================
+ Hits 16740 16747 +7
- Misses 13072 13078 +6
+ Partials 1580 1574 -6
... and 9 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
thanks, merged to master |
Kiss736921
pushed a commit
to Kiss736921/kyuubi
that referenced
this pull request
Mar 23, 2023
…r Spark engine ### _Why are the changes needed?_ ### _How was this patch tested?_ - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible - [ ] Add screenshots for manual tests if appropriate - [ ] [Run test](https://kyuubi.readthedocs.io/en/master/develop_tools/testing.html#running-tests) locally before make a pull request Closes apache#4541 from turboFei/expose. Closes apache#4541 f882b4d [fwang12] engine register attributes Authored-by: fwang12 <fwang12@ebay.com> Signed-off-by: fwang12 <fwang12@ebay.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before make a pull request