Fix the empty last line may causes the session to exit directly #4575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4575 +/- ##
============================================
- Coverage 53.28% 53.27% -0.01%
Complexity 13 13
============================================
Files 573 573
Lines 31501 31502 +1
Branches 4239 4239
============================================
- Hits 16786 16784 -2
- Misses 13135 13137 +2
- Partials 1580 1581 +1
... and 4 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
cxzl25
approved these changes
Mar 22, 2023
turboFei
approved these changes
Mar 22, 2023
turboFei
pushed a commit
that referenced
this pull request
Mar 22, 2023
… directly ### _Why are the changes needed?_ If the last line of the file is a blank line, there may be a cmd whose content is empty but the length is not 0 after split by ";". When running to this cmd, it will return false, causing the session to exit directly. ### _How was this patch tested?_ - [x] Add some test cases that check the changes thoroughly including negative and positive cases if possible vim test.sql and write : <img width="527" alt="image" src="https://user-images.githubusercontent.com/43542750/226647817-855d866e-836c-4c60-bc81-0bb192d3d6ff.png"> then start beeline and source this file successfully and session won't exit： <img width="745" alt="image" src="https://user-images.githubusercontent.com/43542750/226652451-823891f3-2768-4165-8816-c052461d1f9c.png"> <img width="598" alt="image" src="https://user-images.githubusercontent.com/43542750/226650769-25a8becf-4655-41ec-bf91-7ae7e28b7d34.png"> - [x] Add screenshots for manual tests if appropriate - [ ] [Run test](https://kyuubi.readthedocs.io/en/master/develop_tools/testing.html#running-tests) locally before make a pull request Closes #4575 from Kiss736921/fix_file_empty_last_line. Closes #4575 ff3fcb1 [Alex] fix the empty last line may causes the session to exit directly Authored-by: Alex <zoulimin@kanzhun.com> Signed-off-by: fwang12 <fwang12@ebay.com> (cherry picked from commit 06f3884) Signed-off-by: fwang12 <fwang12@ebay.com>
|
Thanks，merged to master and 1.7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
If the last line of the file is a blank line, there may be a cmd whose content is empty but the length is not 0 after split by ";". When running to this cmd, it will return false, causing the session to exit directly.
How was this patch tested?
vim test.sql and write :
then start beeline and source this file successfully and session won't exit：Add screenshots for manual tests if appropriate
Run test locally before make a pull request