Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix empty relation when kill executors #4664

Closed

Conversation

ulysses-you
Copy link
Contributor

@ulysses-you ulysses-you commented Apr 4, 2023

Why are the changes needed?

This pr fixes a corner case when repartition on a local relation. e.g.,

Repartition
      |
LocalRelation

it would throw exception since there is no an actually shuffle happen

java.util.NoSuchElementException: key not found: 3
	at scala.collection.MapLike.default(MapLike.scala:235)
	at scala.collection.MapLike.default$(MapLike.scala:234)
	at scala.collection.AbstractMap.default(Map.scala:63)
	at scala.collection.MapLike.apply(MapLike.scala:144)
	at scala.collection.MapLike.apply$(MapLike.scala:143)
	at scala.collection.AbstractMap.apply(Map.scala:63)
	at org.apache.spark.sql.FinalStageResourceManager.findExecutorToKill(FinalStageResourceManager.scala:122)
	at org.apache.spark.sql.FinalStageResourceManager.killExecutors(FinalStageResourceManager.scala:175)

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before make a pull request

@ulysses-you
Copy link
Contributor Author

thanks, merging to master

@ulysses-you ulysses-you deleted the kill-executors-followup branch April 4, 2023 09:07
@ulysses-you ulysses-you added this to the v1.8.0 milestone Apr 4, 2023
@ulysses-you ulysses-you self-assigned this Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants