[AUTHZ] Check generated policy file in test suite #4677
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
kind:infra
bowenliang123
changed the title
yaooqinn
approved these changes
Apr 10, 2023
pan3793
reviewed
Apr 10, 2023
...hz/src/test/gen/scala/org/apache/kyuubi/plugin/spark/authz/gen/PolicyJsonFileGenerator.scala
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #4677 +/- ##
============================================
+ Coverage 57.92% 57.95% +0.03%
Complexity 13 13
============================================
Files 580 580
Lines 32218 32220 +2
Branches 4304 4304
============================================
+ Hits 18663 18674 +11
+ Misses 11761 11757 -4
+ Partials 1794 1789 -5 see 10 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
bowenliang123
commented
Apr 10, 2023
Comment on lines
-336
to
-341
| <activation> | ||
| <!-- activated when Ranger version is identical to required--> | ||
| <property> | ||
| <name>ranger.version</name> | ||
| <value>2.4.0</value> | ||
| </property> |
There was a problem hiding this comment.
Thanks for ping me, So do we have to specify the profile manually now?
There was a problem hiding this comment.
Yes, and the profile name changed to gen-policy.
pan3793
approved these changes
Apr 10, 2023
yaooqinn
reviewed
Apr 12, 2023
|
Thanks, merged to master. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
genpolicyprofile in CI builds, as the property based activation not auto-triggered as expectedly with propertyranger.version=2.4.0set in project parent pomKYUUBI_UPDATE=1 build/mvn clean test -pl :kyuubi-spark-authz_2.12 -Dtest=none -DwildcardSuites=org.apache.kyuubi.plugin.spark.authz.gen.PolicyJsonFileGenerator -PgenpolicyHow was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before make a pull request