Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve FinalStageResourceManager kill executors #4678

Closed
wants to merge 1 commit into from

Conversation

ulysses-you
Copy link
Contributor

@ulysses-you ulysses-you commented Apr 10, 2023

Why are the changes needed?

This pr change two things:

  1. add a config to kill executors if the plan contains table caches. It's not always safe to kill executors if the cache is referenced by two write-like plan.
  2. force adjustTargetNumExecutors when killing executors. YarnAllocator` might re-request original target executors if DRA has not updated target executors yet. Note, DRA would re-adjust executors if there are more tasks to be executed, so we are safe. It's better to adjuest target num executor once we kill executors.

How was this patch tested?

These issues are found during my POC

@ulysses-you
Copy link
Contributor Author

thanks, merging to master

@ulysses-you ulysses-you deleted the skip-cache branch April 10, 2023 03:45
@ulysses-you ulysses-you added this to the v1.8.0 milestone Apr 10, 2023
@ulysses-you ulysses-you self-assigned this Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants