Support submission timeout for yarn application manager and get the applicationInfo in-memory #4719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turboFei
changed the title
Codecov Report
@@ Coverage Diff @@
## master #4719 +/- ##
============================================
+ Coverage 58.03% 58.05% +0.01%
Complexity 13 13
============================================
Files 580 580
Lines 32270 32241 -29
Branches 4307 4303 -4
============================================
- Hits 18728 18717 -11
+ Misses 11739 11729 -10
+ Partials 1803 1795 -8
... and 15 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
pan3793
reviewed
Apr 17, 2023
| @@ -104,7 +101,6 @@ class BatchJobSubmission( | |||
|
|
|||
| override protected def currentApplicationInfo: Option[ApplicationInfo] = { | |||
There was a problem hiding this comment.
this function has side-effects, should add ()
pan3793
reviewed
Apr 17, 2023
kyuubi-server/src/main/scala/org/apache/kyuubi/operation/BatchJobSubmission.scala
Outdated
Show resolved
Hide resolved
pan3793
approved these changes
Apr 17, 2023
zwangsheng
approved these changes
Apr 18, 2023
|
https://github.com/apache/kyuubi/actions/runs/4728413557/jobs/8389933543?pr=4719 |
always update do not fetch if not exists comments unknown side effects comments fix app start time refactor
pan3793
pushed a commit
that referenced
this pull request
Apr 20, 2023
…r and get the applicationInfo in-memory To prevent the create batch operation stuck. - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible - [ ] Add screenshots for manual tests if appropriate - [x] [Run test](https://kyuubi.readthedocs.io/en/master/develop_tools/testing.html#running-tests) locally before make a pull request Closes #4719 from turboFei/yarn_app_mgr. Closes #4719 1b0da93 [fwang12] check timeout Authored-by: fwang12 <fwang12@ebay.com> Signed-off-by: fwang12 <fwang12@ebay.com>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
To prevent the create batch operation stuck.
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before make a pull request