New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[INFRA] Guidelines for Document and Code contributions #4768
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4768 +/- ##
============================================
- Coverage 58.02% 57.97% -0.05%
Complexity 13 13
============================================
Files 580 581 +1
Lines 32220 32437 +217
Branches 4302 4313 +11
============================================
+ Hits 18696 18806 +110
- Misses 11729 11827 +98
- Partials 1795 1804 +9 see 40 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
docs/contributing/doc/build.rst
Outdated
~~~~~~~~~~~~~ | ||
|
||
.. code-block:: sh | ||
:caption: Sphinx build on unix-like OS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unix-like
docs/contributing/doc/build.rst
Outdated
~~~~~~~ | ||
|
||
.. code-block:: sh | ||
:caption: Sphinx build on windows |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Windows
Thanks, merged to master |
Why are the changes needed?
Guidelines for Document and Code Contributions.
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate