Support yarn-client and yarn-cluster for YarnApplicationOperation #4786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turboFei
force-pushed
the
yarn_client_cluster
branch
from
b4d15b7
to
accab6b
Compare
|
yarn-client and yarn-cluster are removed since apache/spark#25684. But for kyuubi batch, we still support spark-2.3, so I think that this pr is still needed. cc @pan3793 |
Codecov Report
@@ Coverage Diff @@
## master #4786 +/- ##
============================================
- Coverage 57.96% 57.93% -0.03%
Complexity 13 13
============================================
Files 581 581
Lines 32459 32458 -1
Branches 4313 4312 -1
============================================
- Hits 18816 18806 -10
- Misses 11835 11840 +5
- Partials 1808 1812 +4
... and 7 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
pan3793
approved these changes
May 5, 2023
turboFei
added a commit
that referenced
this pull request
May 5, 2023
…onOperation ### _Why are the changes needed?_ The spark master might be yarn-client and yarn-cluster ### _How was this patch tested?_ - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible - [ ] Add screenshots for manual tests if appropriate - [x] [Run test](https://kyuubi.readthedocs.io/en/master/develop_tools/testing.html#running-tests) locally before make a pull request Closes #4786 from turboFei/yarn_client_cluster. Closes #4786 accab6b [fwang12] Support yarn-client and yarn-cluster Authored-by: fwang12 <fwang12@ebay.com> Signed-off-by: fwang12 <fwang12@ebay.com> (cherry picked from commit 07e26a8) Signed-off-by: fwang12 <fwang12@ebay.com>
|
thanks, merged to master and branch-1.7 |
pan3793
pushed a commit
to pan3793/kyuubi
that referenced
this pull request
May 12, 2023
…licationOperation ### _Why are the changes needed?_ The spark master might be yarn-client and yarn-cluster ### _How was this patch tested?_ - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible - [ ] Add screenshots for manual tests if appropriate - [x] [Run test](https://kyuubi.readthedocs.io/en/master/develop_tools/testing.html#running-tests) locally before make a pull request Closes apache#4786 from turboFei/yarn_client_cluster. Closes apache#4786 accab6b [fwang12] Support yarn-client and yarn-cluster Authored-by: fwang12 <fwang12@ebay.com> Signed-off-by: fwang12 <fwang12@ebay.com> (cherry picked from commit 07e26a8) Signed-off-by: fwang12 <fwang12@ebay.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
The spark master might be yarn-client and yarn-cluster
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before make a pull request