Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update readthedocs.yaml #4800

Closed
wants to merge 1 commit into from
Closed

Conversation

yaooqinn
Copy link
Member

@yaooqinn yaooqinn commented May 8, 2023

Why are the changes needed?

  • readthedocs.yml shall be readthedocs.yaml.
  • Add OS version

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before make a pull request

@codecov-commenter
Copy link

Codecov Report

Merging #4800 (ba70cc5) into master (ae3b813) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #4800      +/-   ##
============================================
- Coverage     57.95%   57.92%   -0.03%     
  Complexity       13       13              
============================================
  Files           581      581              
  Lines         32481    32481              
  Branches       4315     4315              
============================================
- Hits          18825    18816       -9     
- Misses        11841    11850       +9     
  Partials       1815     1815              

see 8 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@yaooqinn yaooqinn added this to the v1.8.0 milestone May 8, 2023
@yaooqinn yaooqinn self-assigned this May 8, 2023
@yaooqinn yaooqinn closed this in f8109b0 May 8, 2023
yaooqinn added a commit that referenced this pull request May 8, 2023
### _Why are the changes needed?_

- readthedocs.yml shall be readthedocs.yaml.
- Add OS version

### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

- [ ] Add screenshots for manual tests if appropriate

- [ ] [Run test](https://kyuubi.readthedocs.io/en/master/develop_tools/testing.html#running-tests) locally before make a pull request

Closes #4800 from yaooqinn/readthedocs.

Closes #4800

ba70cc5 [Kent Yao] Update readthedocs.yaml

Authored-by: Kent Yao <yao@apache.org>
Signed-off-by: Kent Yao <yao@apache.org>
(cherry picked from commit f8109b0)
Signed-off-by: Kent Yao <yao@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants