[AUTHZ] Refactor Authz reflection with kyuubi-util's DynMethods #4873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bowenliang123
force-pushed
the
authz-reflect
branch
from
b5c547e
to
916b7af
Compare
bowenliang123
changed the title
Codecov Report
@@ Coverage Diff @@
## master #4873 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 556 556
Lines 30697 30677 -20
Branches 4000 3996 -4
======================================
+ Misses 30697 30677 -20
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
The lineage plugin would also benefit from this in follow-ups since it has similar reflection methods as Authz's. |
pan3793
reviewed
May 23, 2023
kyuubi-util-scala/src/main/scala/org/apache/kyuubi/util/reflect/ReflectUtils.scala
Show resolved
Hide resolved
pan3793
approved these changes
May 23, 2023
|
Pending this PR. Local builds failed unexpectedly. Running |
|
please add |
…t/ReflectUtils.scala
bowenliang123
force-pushed
the
authz-reflect
branch
from
8441e66
to
95d4760
Compare
bowenliang123
changed the title
|
OK. Built and tested successfully by running with |
bowenliang123
changed the title
|
Thanks, merged to master |
huangzhir
pushed a commit
to huangzhir/kyuubi
that referenced
this pull request
May 30, 2023
…il's DynMethods ### _Why are the changes needed?_ - add reflection utils in kyuubi-util-scala, using kyuubi-util's DynMethods - continue to provided simplified reflection calling in scala ### _How was this patch tested?_ - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible - [ ] Add screenshots for manual tests if appropriate - [x] [Run test](https://kyuubi.readthedocs.io/en/master/develop_tools/testing.html#running-tests) locally before make a pull request Closes apache#4873 from bowenliang123/authz-reflect. Closes apache#4873 d0a5084 [liangbowen] import 95d4760 [Cheng Pan] Update kyuubi-util-scala/src/main/scala/org/apache/kyuubi/util/reflect/ReflectUtils.scala 83e70f0 [liangbowen] authz reflect Lead-authored-by: liangbowen <liangbowen@gf.com.cn> Co-authored-by: Cheng Pan <pan3793@gmail.com> Signed-off-by: Cheng Pan <chengpan@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before make a pull request