Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KYUUBI #4305][Bug] Backport HIVE-15820: comment at the head of beeline -e #4967

Closed
wants to merge 9 commits into from

Conversation

turboFei
Copy link
Member

@turboFei turboFei commented Jun 15, 2023

Why are the changes needed?

based on #4965
Close #4305

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before make a pull request

@codecov-commenter
Copy link

Codecov Report

Merging #4967 (314a4bf) into master (01320c4) will not change coverage.
The diff coverage is 0.00%.

@@          Coverage Diff           @@
##           master   #4967   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files         563     563           
  Lines       30997   31015   +18     
  Branches     4044    4047    +3     
======================================
- Misses      30997   31015   +18     
Impacted Files Coverage Δ
...in/java/org/apache/hive/beeline/KyuubiBeeLine.java 0.00% <0.00%> (ø)
...n/java/org/apache/hive/beeline/KyuubiCommands.java 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@turboFei turboFei closed this Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Backport HIVE-15820: comment at the head of beeline -e
2 participants