[TEST] Run JUnit tests on beeline module #4969
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
Does it support JUnit5 ? |
|
No, the scalatest junit plugin only supports Junit 4.x according to the version list at https://www.scalatest.org/plus/junit/versions. |
Codecov Report
@@ Coverage Diff @@
## master #4969 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 561 561
Lines 30969 30969
Branches 4061 4061
======================================
Misses 30969 30969 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
bowenliang123
force-pushed
the
scalatest-junit
branch
from
6cfae7f
to
b0f4e4c
Compare
bowenliang123
force-pushed
the
scalatest-junit
branch
from
b0f4e4c
to
995c83c
Compare
bowenliang123
changed the title
bowenliang123
changed the title
|
The tests can be skipped with
|
turboFei
approved these changes
Jun 16, 2023
|
Do we need to check other java modules？ |
cfmcgrady
approved these changes
Jun 16, 2023
I have checked. we missed the module |
bowenliang123
added a commit
that referenced
this pull request
Jun 16, 2023
### _Why are the changes needed?_ - add `maven-surefire-plugin` to beeline module for running JUnit tests. ### _How was this patch tested?_ - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible - [ ] Add screenshots for manual tests if appropriate - [ ] [Run test](https://kyuubi.readthedocs.io/en/master/develop_tools/testing.html#running-tests) locally before make a pull request Closes #4969 from bowenliang123/scalatest-junit. Closes #4969 995c83c [liangbowen] surefire on beeline Authored-by: liangbowen <liangbowen@gf.com.cn> Signed-off-by: liangbowen <liangbowen@gf.com.cn> (cherry picked from commit de0258b) Signed-off-by: liangbowen <liangbowen@gf.com.cn>
|
Thanks for reviewing. Merged to master / 1.7.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
maven-surefire-pluginto beeline module for running JUnit tests.How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before make a pull request