Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MINOR] Eliminate rawtypes compilation warning in KyuubiBeeLine #4974

Closed
wants to merge 1 commit into from

Conversation

bowenliang123
Copy link
Contributor

@bowenliang123 bowenliang123 commented Jun 16, 2023

Why are the changes needed?

  • Eliminate rawtypes compilation warning in KyuubiBeeLine.java by adding SuppressWarnings annotation of rule rawtypes to BeelineParser implementation
Warning:  [Warn] /home/runner/work/kyuubi/kyuubi/kyuubi-hive-beeline/src/main/java/org/apache/hive/beeline/KyuubiBeeLine.java:148:53:  [rawtypes] found raw type: ListIterator

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before make a pull request

@bowenliang123
Copy link
Contributor Author

bowenliang123 commented Jun 16, 2023

@codecov-commenter
Copy link

Codecov Report

Merging #4974 (994a2d3) into master (eeee5c1) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #4974   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files         561     561           
  Lines       30957   30957           
  Branches     4061    4061           
======================================
  Misses      30957   30957           
Impacted Files Coverage Δ
...in/java/org/apache/hive/beeline/KyuubiBeeLine.java 0.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pan3793 pan3793 added this to the v1.8.0 milestone Jun 18, 2023
@pan3793 pan3793 closed this in c523853 Jun 18, 2023
@pan3793
Copy link
Member

pan3793 commented Jun 18, 2023

Thanks, merged to master

@bowenliang123 bowenliang123 deleted the beeline-rawtypes branch December 4, 2023 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants