Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python JayDeBeApi doc #5094

Closed
wants to merge 7 commits into from
Closed

Conversation

dev-lpq
Copy link
Contributor

@dev-lpq dev-lpq commented Jul 25, 2023

Why are the changes needed?

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before make a pull request

@github-actions github-actions bot added the kind:documentation Documentation is a feature! label Jul 25, 2023
@dev-lpq dev-lpq changed the title Add python doc Add Python JayDeBeApi doc Jul 25, 2023
@cxzl25
Copy link
Contributor

cxzl25 commented Jul 26, 2023

Please use the following command to format jaydebeapi.md

./dev/reformat

OR

mvn spotless:apply

@codecov-commenter
Copy link

codecov-commenter commented Jul 26, 2023

Codecov Report

Merging #5094 (5570ae3) into master (026b88e) will not change coverage.
Report is 1 commits behind head on master.
The diff coverage is n/a.

❗ Current head 5570ae3 differs from pull request most recent head c7d50d7. Consider uploading reports for the commit c7d50d7 to get more accurate results

@@          Coverage Diff           @@
##           master   #5094   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files         564     564           
  Lines       31313   31303   -10     
  Branches     4097    4097           
======================================
+ Misses      31313   31303   -10     

see 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dev-lpq dev-lpq requested a review from cxzl25 July 26, 2023 05:43
@pan3793
Copy link
Member

pan3793 commented Jul 26, 2023

Seems your master is not synced upstream, you can run the following command to fix it.

git checkout master
git reset --hard 026b88e87b38dde87bf1c1a4bc053815528acbd2
git push -f
git checkout add_python_doc
git rebase master
git push -f

@pan3793 pan3793 added this to the v1.7.2 milestone Jul 26, 2023
@pan3793 pan3793 closed this in bbc3fdf Jul 26, 2023
pan3793 pushed a commit that referenced this pull request Jul 26, 2023
### _Why are the changes needed?_

### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

- [ ] Add screenshots for manual tests if appropriate

- [x] [Run test](https://kyuubi.readthedocs.io/en/master/contributing/code/testing.html#running-tests) locally before make a pull request

Closes #5094 from dev-lpq/add_python_doc.

Closes #5094

c7d50d7 [pengqli] upgrade Python-JayDeBeApi doc
41f96fc [pengqli] upgrade Python-JayDeBeApi doc
dd0f91b [pengqli] upgrade Python-JayDeBeApi doc
ae1b7bc [pengqli] upgrade Python-JayDeBeApi doc
189d7c8 [pengqli] upgrade Python-JayDeBeApi doc
2e1e7b4 [pengqli] upgrade Python-JayDeBeApi doc
362a432 [pengqli] add Python-JayDeBeApi doc

Authored-by: pengqli <pengqli@cisco.com>
Signed-off-by: Cheng Pan <chengpan@apache.org>
(cherry picked from commit bbc3fdf)
Signed-off-by: Cheng Pan <chengpan@apache.org>
@pan3793
Copy link
Member

pan3793 commented Jul 26, 2023

Thanks, merged to master/1.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:documentation Documentation is a feature!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants