Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Iterable instead of Seq in kyuubi-ctl commands #5179

Closed
wants to merge 1 commit into from

Conversation

bowenliang123
Copy link
Contributor

@bowenliang123 bowenliang123 commented Aug 18, 2023

Why are the changes needed?

  • Use Iterable instead of Seq in kyuubi-ctl commands for Scala compatibility, as
  1. in Scala 2.13, the scala.Seq is now an alias for scala.collection.immutable.Seq (instead of scala.collection.Seq)
  2. in Scala 2.13, scala.collection.mutable.ListBuffer (or Buffers) does not extend scala.collection.immutable.Seq according to Scala collection migration guide
  3. in both Scala 2.12 and 2.13, ListBuffer (or Buffers) extends scala.collection.mutable.Iterable

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before make a pull request

Was this patch authored or co-authored using generative AI tooling?

@bowenliang123 bowenliang123 marked this pull request as ready for review August 18, 2023 10:37
@codecov-commenter
Copy link

codecov-commenter commented Aug 18, 2023

Codecov Report

Merging #5179 (5e5561d) into master (4213e20) will not change coverage.
Report is 1 commits behind head on master.
The diff coverage is 0.00%.

❗ Current head 5e5561d differs from pull request most recent head 3265e3b. Consider uploading reports for the commit 3265e3b to get more accurate results

@@          Coverage Diff           @@
##           master   #5179   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files         566     566           
  Lines       31699   31703    +4     
  Branches     4134    4134           
======================================
- Misses      31699   31703    +4     
Files Changed Coverage Δ
...he/kyuubi/ctl/cmd/create/CreateServerCommand.scala 0.00% <0.00%> (ø)
...g/apache/kyuubi/ctl/cmd/delete/DeleteCommand.scala 0.00% <0.00%> (ø)
...he/kyuubi/ctl/cmd/delete/DeleteEngineCommand.scala 0.00% <ø> (ø)
...ala/org/apache/kyuubi/ctl/cmd/get/GetCommand.scala 0.00% <0.00%> (ø)
...g/apache/kyuubi/ctl/cmd/get/GetEngineCommand.scala 0.00% <ø> (ø)
...g/apache/kyuubi/ctl/cmd/get/GetServerCommand.scala 0.00% <ø> (ø)
...e/kyuubi/ctl/cmd/list/AdminListEngineCommand.scala 0.00% <0.00%> (ø)
...e/kyuubi/ctl/cmd/list/AdminListServerCommand.scala 0.00% <0.00%> (ø)
...a/org/apache/kyuubi/ctl/cmd/list/ListCommand.scala 0.00% <0.00%> (ø)
...apache/kyuubi/ctl/cmd/list/ListServerCommand.scala 0.00% <ø> (ø)
... and 2 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@bowenliang123 bowenliang123 self-assigned this Aug 21, 2023
@bowenliang123 bowenliang123 added this to the v1.8.0 milestone Aug 21, 2023
@bowenliang123
Copy link
Contributor Author

Thanks, merged to master.

@bowenliang123 bowenliang123 deleted the ctlcmd-iter branch August 21, 2023 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants