[CI] Check style with profiles of Spark 3.4 and 3.5 #5444
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
kind:infra
bowenliang123
changed the title
yaooqinn
approved these changes
Oct 17, 2023
yaooqinn
changed the title
|
There's a blocker issue here. log: https://github.com/apache/kyuubi/actions/runs/6544718529/job/17771748593?pr=5444#step:8:413 Resolve this problem by running scalastyle checks with the e Spark 3.1 profile separately. |
Codecov Report
@@ Coverage Diff @@
## master #5444 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 588 588
Lines 33450 33450
Branches 4400 4400
======================================
Misses 33450 33450 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
bowenliang123
changed the title
bowenliang123
changed the title
bowenliang123
added a commit
that referenced
this pull request
Oct 19, 2023
### _Why are the changes needed?_ - Check style with profile of Spark 3.4 and 3.5 in the style workflow - Isolated scalastyle check for Spark 3.1 profile, as Iceberg 1.3.1 does not support Spark 3.5 ### _How was this patch tested?_ - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible - [ ] Add screenshots for manual tests if appropriate - [x] [Run test](https://kyuubi.readthedocs.io/en/master/contributing/code/testing.html#running-tests) locally before make a pull request ### _Was this patch authored or co-authored using generative AI tooling?_ No. Closes #5444 from bowenliang123/spotless-spark34. Closes #5444 ca98c52 [Bowen Liang] update 9550a4a [Bowen Liang] enable spark-3.1 profile for spotless style checks dae3529 [Bowen Liang] revert order 3e488cf [Bowen Liang] Check with Spark 3.1 profile separately e879f09 [Bowen Liang] revert the order of spark versions in profiles 16456a7 [Bowen Liang] check style with profile of Spark 3.4 and 3.5 Authored-by: Bowen Liang <liangbowen@gf.com.cn> Signed-off-by: Bowen Liang <liangbowen@gf.com.cn> (cherry picked from commit 48bdc7d) Signed-off-by: Bowen Liang <liangbowen@gf.com.cn>
|
Thanks, merged to master (1.9.0) and branch-1.8 (1.8.0). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before make a pull request
Was this patch authored or co-authored using generative AI tooling?
No.