[KYUUBI #5528] Remove duplicate properties tag and respect KYUUBI_LOG_DIR #5528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wForget
changed the title
yaooqinn
approved these changes
Oct 26, 2023
wForget
changed the title
pan3793
approved these changes
Oct 26, 2023
pan3793
pushed a commit
that referenced
this pull request
Oct 26, 2023
…_DIR ### _Why are the changes needed?_ Remove duplicate attribute tags to fix `k8sAuditLogPath` property not found.  and set logDir to KYUUBI_LOG_DIR.  ### _How was this patch tested?_ - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible - [ ] Add screenshots for manual tests if appropriate - [ ] [Run test](https://kyuubi.readthedocs.io/en/master/contributing/code/testing.html#running-tests) locally before make a pull request ### _Was this patch authored or co-authored using generative AI tooling?_ Closes #5528 from wForget/hotfix. Closes #5528 060e396 [wforget] Respect KYUUBI_LOG_DIR a1a808b [wforget] Remove duplicate properties tag Authored-by: wforget <643348094@qq.com> Signed-off-by: Cheng Pan <chengpan@apache.org> (cherry picked from commit fbf3954) Signed-off-by: Cheng Pan <chengpan@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Remove duplicate attribute tags to fix
k8sAuditLogPathproperty not found.and set logDir to KYUUBI_LOG_DIR.
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before make a pull request
Was this patch authored or co-authored using generative AI tooling?