Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TASK][EASY] Refactor the code path of authz #5546

Closed
3 of 4 tasks
Tracked by #5401
AngersZhuuuu opened this issue Oct 27, 2023 · 0 comments
Closed
3 of 4 tasks
Tracked by #5401

[TASK][EASY] Refactor the code path of authz #5546

AngersZhuuuu opened this issue Oct 27, 2023 · 0 comments
Assignees
@AngersZhuuuu
Labels
kind:subtask a subtask of umbrella ticket

Comments

@AngersZhuuuu
Copy link
Contributor

Code of Conduct

Search before asking

  • I have searched in the issues and found no similar issues.

Describe the subtask

Refactor the code path of AUTHZ for supporting making more clear to be customized

Parent issue

#5401

Are you willing to submit PR?

  • Yes. I would be willing to submit a PR with guidance from the Kyuubi community to improve.
  • No. I cannot submit a PR at this time.
@AngersZhuuuu AngersZhuuuu added the kind:subtask a subtask of umbrella ticket label Oct 27, 2023
@AngersZhuuuu AngersZhuuuu mentioned this issue Oct 27, 2023
Open
7 tasks
AngersZhuuuu added a commit to AngersZhuuuu/incubator-kyuubi that referenced this issue Oct 27, 2023
@AngersZhuuuu
[KYUUBI apache#5546][AUTHZ] Refactor the code path of authz
ef21989
@AngersZhuuuu AngersZhuuuu mentioned this issue Oct 27, 2023
Closed
3 tasks
pan3793 added a commit that referenced this issue Oct 29, 2023
@pan3793
Revert "[KYUUBI #5546][AUTHZ] Reorgnize the package names for rules"
67b61df 
This reverts commit 7a0534f.
@AngersZhuuuu AngersZhuuuu mentioned this issue Oct 30, 2023
Closed
3 tasks
pan3793 pushed a commit that referenced this issue Oct 30, 2023
@AngersZhuuuu @pan3793
[KYUUBI #5546][AUTHZ] Reorgnize the package names for rules
22f6ef1 
### _Why are the changes needed?_
To close #5546
Refactor the code path of authz

- Rule is not specify for ranger, extract to a independent path `rule`
- Collect each. rule's class together
- Move RangerConfigProvider to `ranger` package

The output is
<img width="449" alt="截屏2023-10-30 上午10 52 35" src="https://github.com/apache/kyuubi/assets/46485123/6db12dc8-7318-4b18-9ed2-4d66d40d4773">

### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

- [ ] Add screenshots for manual tests if appropriate

- [ ] [Run test](https://kyuubi.readthedocs.io/en/master/contributing/code/testing.html#running-tests) locally before make a pull request

### _Was this patch authored or co-authored using generative AI tooling?_

Closes #5553 from AngersZhuuuu/KYUUBI-5546.

Closes #5546

877f017 [Angerszhuuuu] update
099d093 [Angerszhuuuu] Update RuleReplaceShowObjectCommands.scala
afbfd92 [Angerszhuuuu] Update RuleReplaceShowObjectCommands.scala
72f24bd [Angerszhuuuu] Merge branch 'master' into KYUUBI-5546
cc8f493 [Angerszhuuuu] Update RuleAuthorization.scala
8db7bb8 [Angerszhuuuu] Update RuleAuthorization.scala
8dd49bb [Angerszhuuuu] Merge branch 'master' into KYUUBI-5546
41cc830 [Angerszhuuuu] followcomment
7c449b4 [Angerszhuuuu] follow comment
16f0878 [Angerszhuuuu] update
0a3265f [Angerszhuuuu] Update RuleApplyPermanentViewMarker.scala
4ed26a3 [Angerszhuuuu] follow comment
ce94bf8 [Angerszhuuuu] Update AuthzConfigurationCheckerSuite.scala
3bc9d2f [Angerszhuuuu] Update AuthzConfigurationCheckerSuite.scala
dbee531 [Angerszhuuuu] update
6a9b94c [Angerszhuuuu] Update PrivilegesBuilder.scala
ed9e9dc [Angerszhuuuu] Update RangerSparkExtensionSuite.scala
50ac9bc [Angerszhuuuu] update
0faed7f [Angerszhuuuu] Merge branch 'master' into KYUUBI-5546
ef21989 [Angerszhuuuu] [KYUUBI #5546][AUTHZ] Refactor the code path of authz

Authored-by: Angerszhuuuu <angers.zhu@gmail.com>
Signed-off-by: Cheng Pan <chengpan@apache.org>
@pan3793 pan3793 changed the title [Subtask] Refactor the code path of authz [TASK][EASY] Refactor the code path of authz Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AngersZhuuuu AngersZhuuuu

Labels
kind:subtask a subtask of umbrella ticket
Projects
No open projects
2023 Kyuubi Code Contribution Program
Status: Done
Milestone
No milestone
1 participant
@AngersZhuuuu