Skip to content

Conversation

@AngersZhuuuu
Copy link
Contributor

@AngersZhuuuu AngersZhuuuu commented Oct 30, 2023

Why are the changes needed?

To close #5546
Refactor the code path of authz

  • Rule is not specify for ranger, extract to a independent path rule
  • Collect each. rule's class together
  • Move RangerConfigProvider to ranger package

The output is
截屏2023-10-30 上午10 52 35

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before make a pull request

Was this patch authored or co-authored using generative AI tooling?

@pan3793 pan3793 added this to the v1.9.0 milestone Oct 30, 2023
@codecov-commenter
Copy link

codecov-commenter commented Oct 30, 2023

Codecov Report

Merging #5553 (877f017) into master (0e85702) will decrease coverage by 0.09%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #5553      +/-   ##
============================================
- Coverage     61.41%   61.33%   -0.09%     
  Complexity       23       23              
============================================
  Files           600      600              
  Lines         34316    34316              
  Branches       4501     4501              
============================================
- Hits          21076    21048      -28     
- Misses        11108    11126      +18     
- Partials       2132     2142      +10     
Files Coverage Δ
.../kyuubi/plugin/spark/authz/PrivilegesBuilder.scala 90.69% <ø> (ø)
...ugin/spark/authz/ranger/RangerConfigProvider.scala 80.00% <ø> (ø)
...ugin/spark/authz/ranger/RangerSparkExtension.scala 100.00% <100.00%> (ø)
.../plugin/spark/authz/ranger/RuleAuthorization.scala 85.71% <ø> (ø)
...in/spark/authz/ranger/SparkRangerAdminPlugin.scala 72.97% <ø> (ø)
.../plugin/spark/authz/rule/RuleEliminateMarker.scala 60.00% <ø> (ø)
.../authz/rule/RuleEliminatePermanentViewMarker.scala 25.00% <100.00%> (ø)
...he/kyuubi/plugin/spark/authz/rule/RuleHelper.scala 100.00% <ø> (ø)
.../authz/rule/config/AuthzConfigurationChecker.scala 63.63% <ø> (ø)
...thz/rule/datamasking/DataMaskingStage0Marker.scala 57.14% <ø> (ø)
... and 11 more

... and 13 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pan3793 pan3793 closed this in 22f6ef1 Oct 30, 2023
@pan3793
Copy link
Member

pan3793 commented Oct 30, 2023

Merged to master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[TASK][EASY] Refactor the code path of authz

4 participants