Use TestContainerForAll for testing JDBC engine with testcontainers #5862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5862 +/- ##
============================================
- Coverage 61.40% 61.30% -0.10%
Complexity 23 23
============================================
Files 612 612
Lines 36239 36239
Branches 4967 4967
============================================
- Hits 22251 22217 -34
- Misses 11593 11619 +26
- Partials 2395 2403 +8 ☔ View full report in Codecov by Sentry. |
bowenliang123
force-pushed
the
jdbc-container
branch
from
fe48bd0
to
29e8512
Compare
pan3793
approved these changes
Dec 18, 2023
|
Thanks, merged to master (1.9.0). |
zhaohehuhu
pushed a commit
to zhaohehuhu/incubator-kyuubi
that referenced
this pull request
Mar 21, 2024
…with testcontainers # 🔍 Description ## Issue References 🔗 As described. ## Describe Your Solution 🔧 - replacing the usage of `ForAllTestContainer` with `TestContainerForAll`, simplifying the lifecycle for starting / stopping the containers and fetching the configs from the containers - use `testcontainers-scala-postgresql` for testing with PostgreSQL containers - add version 16 for PostgreSQL image tag ## Types of changes 🔖 - [ ] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Test Plan 🧪 #### Behavior Without This Pull Request ⚰️ No behaviour changes. #### Behavior With This Pull Request 🎉 No behaviour changes. #### Related Unit Tests JDBC Engine IT. --- # Checklists ## 📝 Author Self Checklist - [x] My code follows the [style guidelines](https://kyuubi.readthedocs.io/en/master/contributing/code/style.html) of this project - [x] I have performed a self-review - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [x] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html) ## 📝 Committer Pre-Merge Checklist - [ ] Pull request title is okay. - [ ] No license issues. - [ ] Milestone correctly set? - [ ] Test coverage is ok - [ ] Assignees are selected. - [ ] Minimum number of approvals - [ ] No changes are requested **Be nice. Be informative.** Closes apache#5862 from bowenliang123/jdbc-container. Closes apache#5862 29e8512 [Bowen Liang] TestContainerForAll Authored-by: Bowen Liang <liangbowen@gf.com.cn> Signed-off-by: liangbowen <liangbowen@gf.com.cn>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔍 Description
Issue References 🔗
As described.
Describe Your Solution 🔧
ForAllTestContainerwithTestContainerForAll, simplifying the lifecycle for starting / stopping the containers and fetching the configs from the containerstestcontainers-scala-postgresqlfor testing with PostgreSQL containersTypes of changes 🔖
Test Plan 🧪
Behavior Without This Pull Request ⚰️
No behaviour changes.
Behavior With This Pull Request 🎉
No behaviour changes.
Related Unit Tests
JDBC Engine IT.
Checklists
📝 Author Self Checklist
📝 Committer Pre-Merge Checklist
Be nice. Be informative.