Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUILD] Remove the extension spark jars before build to avoid include unspecified version #6129

Closed
wants to merge 3 commits into from

Conversation

zwangsheng
Copy link
Contributor

🔍 Description

Issue References 🔗

This pull request fixes #5836 (comment)

Describe Your Solution 🔧

Remove the remain extension spark jars in related target dir before start to package.

Aims to avoid include unspecified version.

Types of changes 🔖

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Test Plan 🧪

Behavior Without This Pull Request ⚰️

Before this PR:

./build/dist -Pspark-3.1 ...
# your will get expected package, then you run the following command
./build/dist -Pspark-3.3
# you will find the final package include the spark 3.1 extension jar, which is un-expected.

Behavior With This Pull Request 🎉

After this PR, will clean up those extension spark jars before build to ensure we won't package the unspecified extension jar.

Related Unit Tests

None

Checklist 📝

Be nice. Be informative.

@zwangsheng zwangsheng requested review from wForget and cxzl25 and removed request for wForget March 5, 2024 09:18
build/dist Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Mar 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.15%. Comparing base (49456bb) to head (d824491).
Report is 1 commits behind head on master.

❗ Current head d824491 differs from pull request most recent head 3e5f434. Consider uploading reports for the commit 3e5f434 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6129      +/-   ##
============================================
- Coverage     61.17%   61.15%   -0.02%     
  Complexity       23       23              
============================================
  Files           624      624              
  Lines         37260    37260              
  Branches       5046     5046              
============================================
- Hits          22793    22788       -5     
- Misses        12011    12021      +10     
+ Partials       2456     2451       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zwangsheng
Copy link
Contributor Author

zwangsheng commented Mar 6, 2024

Made some changes, using maven clean plugin to help clean up those jars instead of script, please review again @ulysses-you @wForget thanks

After second thought, we should still do this in script to avoid trigger the clean logic multi times.

pom.xml Outdated Show resolved Hide resolved
pom.xml Outdated Show resolved Hide resolved
build/dist Outdated Show resolved Hide resolved
@pan3793 pan3793 added this to the v1.9.0 milestone Mar 6, 2024
@pan3793 pan3793 closed this in e4a0644 Mar 6, 2024
@pan3793
Copy link
Member

pan3793 commented Mar 6, 2024

Thanks, merged to master

zhaohehuhu pushed a commit to zhaohehuhu/incubator-kyuubi that referenced this pull request Mar 21, 2024
…uild to avoid include unspecified version

# 🔍 Description
## Issue References 🔗

This pull request fixes apache#5836 (comment)

## Describe Your Solution 🔧

Remove the remain extension spark jars in related target dir before start to package.

Aims to avoid include unspecified version.

## Types of changes 🔖

- [x] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)

## Test Plan 🧪

#### Behavior Without This Pull Request ⚰️

Before this PR:
```shel
./build/dist -Pspark-3.1 ...
# your will get expected package, then you run the following command
./build/dist -Pspark-3.3
# you will find the final package include the spark 3.1 extension jar, which is un-expected.
```

#### Behavior With This Pull Request 🎉

After this PR, will clean up those extension spark jars before build to ensure we won't package the unspecified extension jar.

#### Related Unit Tests

None
---

# Checklist 📝

- [x] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html)

**Be nice. Be informative.**

Closes apache#6129 from zwangsheng/KYUUBI/clean_up_jasrs.

Closes apache#6129

3e5f434 [Cheng Pan] Update build/dist
d824491 [zwangsheng] Remove support spark 3.1
c83b79a [zwangsheng] [BUILD] Remove the extension spark jars before build

Lead-authored-by: zwangsheng <binjieyang@apache.org>
Co-authored-by: Cheng Pan <pan3793@gmail.com>
Signed-off-by: Cheng Pan <chengpan@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants