Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify Maven dependency management after dropping building support for Spark 3.1 #6131

Closed
wants to merge 4 commits into from

Conversation

pan3793
Copy link
Member

@pan3793 pan3793 commented Mar 5, 2024

🔍 Description

Issue References 🔗

SPARK-33212 (fixed in 3.2.0) moves from hadoop-client to shaded hadoop client, to simplify the dependency management, previously , we add some workaround to handle Spark 3.1 dependency issues. As we removed building support for Spark 3.1 now, we can remove those workaround to simplify pom.xml

Describe Your Solution 🔧

As above.

Types of changes 🔖

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Test Plan 🧪

Pass GA.


Checklist 📝

Be nice. Be informative.

@codecov-commenter
Copy link

codecov-commenter commented Mar 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.10%. Comparing base (9e7f2d0) to head (d6dcec3).
Report is 1 commits behind head on master.

❗ Current head d6dcec3 differs from pull request most recent head 1341065. Consider uploading reports for the commit 1341065 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6131      +/-   ##
============================================
- Coverage     61.17%   61.10%   -0.07%     
  Complexity       23       23              
============================================
  Files           624      624              
  Lines         37260    37260              
  Branches       5046     5046              
============================================
- Hits          22795    22769      -26     
- Misses        12013    12031      +18     
- Partials       2452     2460       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pan3793 pan3793 changed the title WIP simplify pom Simplify Maven dependency management after dropping building support for Spark 3.1 Mar 6, 2024
@pan3793 pan3793 marked this pull request as ready for review March 6, 2024 08:04
@pan3793 pan3793 requested a review from cxzl25 March 6, 2024 08:04
@pan3793 pan3793 self-assigned this Mar 6, 2024
@pan3793 pan3793 added this to the v1.9.0 milestone Mar 6, 2024
@pan3793 pan3793 closed this in f1cf1e4 Mar 6, 2024
@pan3793
Copy link
Member Author

pan3793 commented Mar 6, 2024

Thanks, merged to master

@pan3793 pan3793 deleted the 3-1-cleanup branch March 7, 2024 02:26
zhaohehuhu pushed a commit to zhaohehuhu/incubator-kyuubi that referenced this pull request Mar 21, 2024
…ing building support for Spark 3.1

# 🔍 Description
## Issue References 🔗

SPARK-33212 (fixed in 3.2.0) moves from `hadoop-client` to shaded hadoop client, to simplify the dependency management, previously , we add some workaround to handle Spark 3.1 dependency issues. As we removed building support for Spark 3.1 now, we can remove those workaround to simplify `pom.xml`

## Describe Your Solution 🔧

As above.

## Types of changes 🔖

- [ ] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)

## Test Plan 🧪

Pass GA.

---

# Checklist 📝

- [x] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html)

**Be nice. Be informative.**

Closes apache#6131 from pan3793/3-1-cleanup.

Closes apache#6131

1341065 [Cheng Pan] nit
1d7323f [Cheng Pan] fix
9e2e3b7 [Cheng Pan] nit
271166b [Cheng Pan] test

Authored-by: Cheng Pan <chengpan@apache.org>
Signed-off-by: Cheng Pan <chengpan@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants