Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dockerfile.HMS for testing #6143

Closed
wants to merge 1 commit into from

Conversation

zhouyifan279
Copy link
Contributor

@zhouyifan279 zhouyifan279 commented Mar 7, 2024

🔍 Description

Issue References 🔗

Currently, we start a LocalMetaServer and MiniKDC for testing Hive delegation token retrieving, it pulls Hive jars into Kyuubi server's test classpath, and eventually messes up the classpath.

Describe Your Solution 🔧

Leverage the container to launch a kerberized HMS to avoid involving Hive jars.

This PR adds a Dockerfile to provide a kerberized HMS.

Types of changes 🔖

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Test Plan 🧪

Manually test, and review,


Checklist 📝

Be nice. Be informative.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.11%. Comparing base (8cc9b98) to head (66ebbfa).

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #6143   +/-   ##
=========================================
  Coverage     61.11%   61.11%           
  Complexity       24       24           
=========================================
  Files           625      625           
  Lines         37234    37234           
  Branches       5028     5028           
=========================================
+ Hits          22755    22757    +2     
+ Misses        12036    12026   -10     
- Partials       2443     2451    +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pan3793 pan3793 changed the title [WIP] Add HiveMetaStore Dockerfile Add Dockerfile.HMS for testing Mar 10, 2024
@pan3793 pan3793 added this to the v1.9.0 milestone Mar 10, 2024
@pan3793
Copy link
Member

pan3793 commented Mar 10, 2024

Thanks, merged to master

@pan3793 pan3793 closed this in 992042b Mar 10, 2024
zhouyifan279 added a commit to zhouyifan279/kyuubi that referenced this pull request Mar 11, 2024
# 🔍 Description
## Issue References 🔗

Currently, we start a `LocalMetaServer` and `MiniKDC` for testing Hive delegation token retrieving, it pulls Hive jars into Kyuubi server's test classpath, and eventually messes up the classpath.

## Describe Your Solution 🔧

Leverage the container to launch a kerberized HMS to avoid involving Hive jars.

This PR adds a Dockerfile to provide a kerberized HMS.

## Types of changes 🔖

- [ ] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)

## Test Plan 🧪

Manually test, and review,

---

# Checklist 📝

- [x] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html)

**Be nice. Be informative.**

Closes apache#6143 from zhouyifan279/hms-docker.

Closes apache#6143

66ebbfa [zhouyifan279] Add HiveMetaStore Dockerfile

Authored-by: zhouyifan279 <zhouyifan279@gmail.com>
Signed-off-by: Cheng Pan <chengpan@apache.org>
zhaohehuhu pushed a commit to zhaohehuhu/incubator-kyuubi that referenced this pull request Mar 21, 2024
# 🔍 Description
## Issue References 🔗

Currently, we start a `LocalMetaServer` and `MiniKDC` for testing Hive delegation token retrieving, it pulls Hive jars into Kyuubi server's test classpath, and eventually messes up the classpath.

## Describe Your Solution 🔧

Leverage the container to launch a kerberized HMS to avoid involving Hive jars.

This PR adds a Dockerfile to provide a kerberized HMS.

## Types of changes 🔖

- [ ] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)

## Test Plan 🧪

Manually test, and review,

---

# Checklist 📝

- [x] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html)

**Be nice. Be informative.**

Closes apache#6143 from zhouyifan279/hms-docker.

Closes apache#6143

66ebbfa [zhouyifan279] Add HiveMetaStore Dockerfile

Authored-by: zhouyifan279 <zhouyifan279@gmail.com>
Signed-off-by: Cheng Pan <chengpan@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants