Distinguish the collect mode of different engines #6201
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pan3793
reviewed
Mar 20, 2024
| .doc("When true, the result will be sequentially calculated and returned to" + | ||
| s" the Spark driver. Note that, ${OPERATION_RESULT_MAX_ROWS.key} will be ignored" + | ||
| " on incremental collect mode. It fallback to `kyuubi.operation.incremental.collect`") | ||
| .version("1.9.0") |
github-actions
bot
added
kind:documentation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6201 +/- ##
============================================
+ Coverage 58.47% 59.27% +0.79%
Complexity 24 24
============================================
Files 649 649
Lines 39312 40096 +784
Branches 5415 5454 +39
============================================
+ Hits 22988 23766 +778
- Misses 13856 13858 +2
- Partials 2468 2472 +4 ☔ View full report in Codecov by Sentry. |
pan3793
approved these changes
Mar 20, 2024
pan3793
changed the title
|
Thanks, merged to master |
zhaohehuhu
pushed a commit
to zhaohehuhu/incubator-kyuubi
that referenced
this pull request
Mar 21, 2024
# 🔍 Description ## Issue References 🔗 ## Describe Your Solution 🔧 Currently, Spark, JDBC, and TRINO engines support incremental collection, but they share the same configuration option `kyuubi.operation.incremental.collect`. Sometimes, it's necessary to enable incremental collection only for specific engines, which requires distinguishing between them. ## Types of changes 🔖 - [ ] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Test Plan 🧪 #### Behavior Without This Pull Request ⚰️ #### Behavior With This Pull Request 🎉 #### Related Unit Tests --- # Checklist 📝 - [ ] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html) **Be nice. Be informative.** Closes apache#6201 from lsm1/branch-distinguish-engine-collect-mode. Closes apache#6201 3c43d2c [senmiaoliu] fix conf version aa53231 [senmiaoliu] distinguish kyuubi.operation.incremental.collect for engine type Authored-by: senmiaoliu <senmiaoliu@trip.com> Signed-off-by: Cheng Pan <chengpan@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔍 Description
Issue References 🔗
Describe Your Solution 🔧
Currently, Spark, JDBC, and TRINO engines support incremental collection, but they share the same configuration option
kyuubi.operation.incremental.collect. Sometimes, it's necessary to enable incremental collection only for specific engines, which requires distinguishing between them.Types of changes 🔖
Test Plan 🧪
Behavior Without This Pull Request ⚰️
Behavior With This Pull Request 🎉
Related Unit Tests
Checklist 📝
Be nice. Be informative.