[KYUUBI #4847][FOLLOWUP] Exclude the alive probe sessions in terminating checker #6355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turboFei
changed the title
4 tasks
turboFei
force-pushed
the
engine_idle
branch
2 times, most recently
from
5749e48
to
a47f023
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6355 +/- ##
============================================
- Coverage 58.49% 58.42% -0.07%
Complexity 24 24
============================================
Files 653 653
Lines 39865 39887 +22
Branches 5481 5483 +2
============================================
- Hits 23319 23304 -15
- Misses 14055 14080 +25
- Partials 2491 2503 +12 ☔ View full report in Codecov by Sentry. |
wForget
reviewed
May 6, 2024
kyuubi-common/src/main/scala/org/apache/kyuubi/session/SessionManager.scala
Outdated
Show resolved
Hide resolved
turboFei
added a commit
that referenced
this pull request
May 9, 2024
…ing checker # 🔍 Description ## Issue References 🔗 This pull request fixes # follow up of #4847 Address comments: #4847 (comment) ## Describe Your Solution 🔧 In this pr, when checking the engine terminating, it will ignore the alive probe sessions. ## Types of changes 🔖 - [ ] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Test Plan 🧪 #### Behavior Without This Pull Request ⚰️ #### Behavior With This Pull Request 🎉 #### Related Unit Tests --- # Checklist 📝 - [x] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html) **Be nice. Be informative.** Closes #6355 from turboFei/engine_idle. Closes #4847 a8e26e7 [Wang, Fei] comments 418d0b4 [Wang, Fei] val Authored-by: Wang, Fei <fwang12@ebay.com> Signed-off-by: Wang, Fei <fwang12@ebay.com> (cherry picked from commit 88b2460) Signed-off-by: Wang, Fei <fwang12@ebay.com>
turboFei
added a commit
that referenced
this pull request
May 9, 2024
…ing checker # 🔍 Description ## Issue References 🔗 This pull request fixes # follow up of #4847 Address comments: #4847 (comment) ## Describe Your Solution 🔧 In this pr, when checking the engine terminating, it will ignore the alive probe sessions. ## Types of changes 🔖 - [ ] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Test Plan 🧪 #### Behavior Without This Pull Request ⚰️ #### Behavior With This Pull Request 🎉 #### Related Unit Tests --- # Checklist 📝 - [x] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html) **Be nice. Be informative.** Closes #6355 from turboFei/engine_idle. Closes #4847 a8e26e7 [Wang, Fei] comments 418d0b4 [Wang, Fei] val Authored-by: Wang, Fei <fwang12@ebay.com> Signed-off-by: Wang, Fei <fwang12@ebay.com> (cherry picked from commit 88b2460) Signed-off-by: Wang, Fei <fwang12@ebay.com>
|
thanks, merged to master/1.9.1/1.8.3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔍 Description
Issue References 🔗
This pull request fixes #
follow up of #4847
Address comments: #4847 (comment)
Describe Your Solution 🔧
In this pr, when checking the engine terminating, it will ignore the alive probe sessions.
Types of changes 🔖
Test Plan 🧪
Behavior Without This Pull Request ⚰️
Behavior With This Pull Request 🎉
Related Unit Tests
Checklist 📝
Be nice. Be informative.