Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve log message for YARN getApplicationInfoByTag #6366

Closed
wants to merge 2 commits into from

Conversation

pan3793
Copy link
Member

@pan3793 pan3793 commented May 7, 2024

🔍 Description

Unify the words and provide the tag for the waiting submission case.

Types of changes 🔖

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Test Plan 🧪

Manually review.


Checklist 📝

Be nice. Be informative.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 50.00000% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 58.43%. Comparing base (28d8c8e) to head (30e3fde).

Files Patch % Lines
...pache/kyuubi/engine/YarnApplicationOperation.scala 50.00% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6366      +/-   ##
============================================
+ Coverage     58.41%   58.43%   +0.01%     
  Complexity       24       24              
============================================
  Files           653      653              
  Lines         39880    39881       +1     
  Branches       5481     5481              
============================================
+ Hits          23296    23304       +8     
+ Misses        14083    14077       -6     
+ Partials       2501     2500       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pan3793 pan3793 requested review from wForget and zwangsheng May 7, 2024 09:49
@pan3793 pan3793 self-assigned this May 8, 2024
@pan3793 pan3793 closed this in d19119b May 8, 2024
pan3793 added a commit that referenced this pull request May 8, 2024
# 🔍 Description

Unify the words and provide the tag for the waiting submission case.

## Types of changes 🔖

- [ ] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)

## Test Plan 🧪

Manually review.

---

# Checklist 📝

- [x] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html)

**Be nice. Be informative.**

Closes #6366 from pan3793/improve-log.

Closes #6366

30e3fde [Cheng Pan] fix style
a3b36ea [Cheng Pan] Improve log message for YARN getApplicationInfoByTag

Authored-by: Cheng Pan <chengpan@apache.org>
Signed-off-by: Cheng Pan <chengpan@apache.org>
(cherry picked from commit d19119b)
Signed-off-by: Cheng Pan <chengpan@apache.org>
pan3793 added a commit that referenced this pull request May 8, 2024
# 🔍 Description

Unify the words and provide the tag for the waiting submission case.

## Types of changes 🔖

- [ ] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)

## Test Plan 🧪

Manually review.

---

# Checklist 📝

- [x] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html)

**Be nice. Be informative.**

Closes #6366 from pan3793/improve-log.

Closes #6366

30e3fde [Cheng Pan] fix style
a3b36ea [Cheng Pan] Improve log message for YARN getApplicationInfoByTag

Authored-by: Cheng Pan <chengpan@apache.org>
Signed-off-by: Cheng Pan <chengpan@apache.org>
(cherry picked from commit d19119b)
Signed-off-by: Cheng Pan <chengpan@apache.org>
@pan3793 pan3793 added this to the v1.8.3 milestone May 8, 2024
@pan3793
Copy link
Member Author

pan3793 commented May 8, 2024

Thanks, merged to master/1.9.1/1.8.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants