[METRICS] Remove unnecessary Guava Cache #637
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pan3793
commented
May 13, 2021
| def incAndGetCount(key: String): Long = synchronized { | ||
| val counter = registry.counter(key) | ||
| counter.inc(1L) | ||
| counter.getCount |
There was a problem hiding this comment.
The return value never used, if return Unit, we can remove synchronized
Codecov Report
@@ Coverage Diff @@
## master #637 +/- ##
============================================
- Coverage 79.88% 7.21% -72.68%
- Complexity 0 132 +132
============================================
Files 120 120
Lines 4683 4674 -9
Branches 563 562 -1
============================================
- Hits 3741 337 -3404
- Misses 625 4293 +3668
+ Partials 317 44 -273 Continue to review full report at Codecov.
|
ulysses-you
reviewed
May 14, 2021
|
|
||
| def incCount(key: String): Unit = { | ||
| val counter = registry.counter(key) | ||
| counter.inc(1L) |
There was a problem hiding this comment.
this method is thread safe ?
nvm, I see this object is singleton.
ulysses-you
approved these changes
May 14, 2021
yaooqinn
approved these changes
May 14, 2021
yaooqinn
pushed a commit
that referenced
this pull request
May 14, 2021
<!-- Thanks for sending a pull request! Here are some tips for you: 1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/contributions.html 2. If the PR is related to an issue in https://github.com/NetEase/kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'. 3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'. --> ### _Why are the changes needed?_ <!-- Please clarify why the changes are needed. For instance, 1. If you add a feature, you can talk about the use case of it. 2. If you fix a bug, you can clarify why it is a bug. --> `MetricRegistry` hold counters in `ConcurrentHashMap`, it's unnecessary to use Guava Cache. ### _How was this patch tested?_ - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible - [ ] Add screenshots for manual tests if appropriate - [x] [Run test](https://kyuubi.readthedocs.io/en/latest/tools/testing.html#running-tests) locally before make a pull request Closes #637 from pan3793/metrics. Closes #637 aee29f1 [Cheng Pan] remove synchronized a8d607b [Cheng Pan] [METRICS] Remove unnecessary Guava Cache Authored-by: Cheng Pan <379377944@qq.com> Signed-off-by: Kent Yao <yao@apache.org> (cherry picked from commit d20a92e) Signed-off-by: Kent Yao <yao@apache.org>
|
thanks, merged to master for v1.3.0 and branch 1.2 for v1.2.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
MetricRegistryhold counters inConcurrentHashMap, it's unnecessary to use Guava Cache.How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before make a pull request