Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KYUUBI #6506] kyuubi-beeline supports --conf #6511

Closed
wants to merge 3 commits into from

Conversation

BruceWong96
Copy link
Contributor

🔍 Description

Issue References 🔗

This pull request fixes #6506

Describe Your Solution 🔧

Set the alias --conf to --hiveconf.

Types of changes 🔖

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Test Plan 🧪

Behavior Without This Pull Request ⚰️

# use --hiveconf or --hivevar to set some configurations
kyuubi-beeline -u 'jdbc:kyuubi://kyuubi:10009/' \
    --hiveconf kyuubi.operation.result.format=arrow \
    --hiveconf kyuubi.operation.incremental.collect=true-f \
    --hivevar app_name=xxx \
    xxx.sql

Behavior With This Pull Request 🎉

# use --conf to set some configurations
kyuubi-beeline -u 'jdbc:kyuubi://kyuubi:10009/' \
    --conf kyuubi.operation.result.format=arrow \
    --conf kyuubi.operation.incremental.collect=true-f \
    --conf app_name=xxx \
    xxx.sql

Related Unit Tests


Checklist 📝

Be nice. Be informative.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 13 lines in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (f1bb408) to head (7a81455).
Report is 1 commits behind head on master.

Files Patch % Lines
...src/main/java/org/apache/hive/beeline/BeeLine.java 0.00% 13 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##           master   #6511   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files         677     677           
  Lines       41734   41746   +12     
  Branches     5704    5706    +2     
======================================
- Misses      41734   41746   +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pan3793 pan3793 added this to the v1.10.0 milestone Jun 27, 2024
@pan3793 pan3793 changed the title [KYUUBI #6506] kyuubi-beeline supports --conf. [KYUUBI #6506] kyuubi-beeline supports --conf Jun 27, 2024
@pan3793 pan3793 closed this in 28a1c73 Jun 27, 2024
@pan3793
Copy link
Member

pan3793 commented Jun 27, 2024

Thanks, merged to master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] kyuubi-beeline supports --conf
3 participants