Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add price_monthly in extra dict to digitalocean sizes #1021

Closed
wants to merge 1 commit into from
Closed

Add price_monthly in extra dict to digitalocean sizes #1021

wants to merge 1 commit into from

Conversation

fjros
Copy link
Contributor

@fjros fjros commented Apr 4, 2017

Add price_monthly extra param to digitalocean sizes

Description

DigitalOcean sizes are commonly referred to by their monthly price. This PR makes libcloud expose such information within the extra dictionary of Size. This new field is named 'price_monthly', as in the DigitalOcean API.

Status

  • done, ready for review

@tonybaloney
Copy link
Contributor

Thanks @fjros what about price_hourly? I can see that in the API too

@fjros
Copy link
Contributor Author

fjros commented Apr 10, 2017

Hi @tonybaloney! price_hourly is already exposed as the price attribute of class NodeSize. For the sake of uniformity wrt other drivers, I think it's ok to leave it there and don't duplicate such value in the extra dict.

@tonybaloney
Copy link
Contributor

👍

@asfgit asfgit closed this in 8a694df Apr 10, 2017
asfgit pushed a commit that referenced this pull request Apr 10, 2017
@tonybaloney
Closes #1021
9f4d0a2 
Closes #543
Closes #547
Closes #572
Closes #586
Closes #598
Closes #600
Closes #613
Closes #628
Closes #678
Closes #784
Closes #791
Closes #907
Closes #819
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fjros @tonybaloney