[LIBCLOUD-763] Simplify str2dicts util function#613
Closed
annp89 wants to merge 1 commit intoapache:trunkfrom
Closed
[LIBCLOUD-763] Simplify str2dicts util function#613annp89 wants to merge 1 commit intoapache:trunkfrom
annp89 wants to merge 1 commit intoapache:trunkfrom
Conversation
annp89
force-pushed
the
LIBCLOUD-763_simplify_util_function
branch
from
38a2cc4 to
6a52243
Compare
Contributor
|
@annp89 do you still want to keep this open? I'd suggest running a pdb session over it to diagnose the failing test, it suggests it would fail in prod too looking at the error. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference: https://issues.apache.org/jira/browse/LIBCLOUD-763
Note about tests:
test_str2dictsin (libcloud.test.compute.test_cloudsigma_v1_0.CloudSigmaAPI10IndiretTestCase) passes.But there are other functions in the same test suite that are failing. Not sure what's going on but I'll investigate.