New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LIBCLOUD-960: Expand GCE Firewall options coverage #1144
Conversation
Codecov Report
@@ Coverage Diff @@
## trunk #1144 +/- ##
==========================================
+ Coverage 85.49% 86.12% +0.63%
==========================================
Files 348 348
Lines 66579 66956 +377
Branches 5925 5947 +22
==========================================
+ Hits 56924 57669 +745
+ Misses 7247 6857 -390
- Partials 2408 2430 +22
Continue to review full report at Codecov.
|
Thank you for your contribution! Unfortunately the test coverage of libcloud/compute/drivers/gce.py is getting lower with the change, but we want it to be higher, so that your changes keep working in the future. As you know, this is important as this is not something that is easy to test in real conditions. See https://codecov.io/gh/apache/libcloud/pull/1144/src/libcloud/compute/drivers/gce.py#L3198 for an example of bad coverage. Thanks. |
I think these are Travis or other issues - I didn't touch what's failing. But I added tests! |
@maxlip Thanks. However you do have lint errors:
Rebasing on top of trunk would solve the paramiko issue and would allow me to see the coverage easily. Do you think you could do that? Thanks! |
Sorry, I realized that the paramiko failure is not your fault. You only have the lint to fix. Thanks. |
Just making sure it's clear that linting looks fixed - CI is now all good. |
@@ -8215,7 +8284,7 @@ def _to_firewall(self, firewall): | |||
""" | |||
Return a Firewall object from the JSON-response dictionary. | |||
|
|||
:param firewall: The dictionary describing the firewall. | |||
:param firewall: The dictionary deFscribing the firewall. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's an extra F here. I'll remove it.
Thank you @maxlip! Merged in trunk! ✨ I've credited you as "maxlip". Would you like me to use something else? |
Thanks for fixing that Quentin - "maxlip" is good for me. |
Expand GCE Firewall options coverage
Description
Expanding coverage for full range of GCP firewall rule options currently in GA:
I've preserved the existing defaults.
Issue Link: https://issues.apache.org/jira/browse/LIBCLOUD-960
Status
Checklist (tick everything that applies)