LIBCLOUD-960: Expand GCE Firewall options coverage

[maxlip]

Expand GCE Firewall options coverage

Description

Expanding coverage for full range of GCP firewall rule options currently in GA:

• Ingress or Egress direction
• Allow or Deny action
• Set Description and Priority values
• Define source and/or targets by service account

I've preserved the existing defaults.

Issue Link: https://issues.apache.org/jira/browse/LIBCLOUD-960

Status

• done, ready for review

Checklist (tick everything that applies)

• Code linting (required, can be done after the PR checks)
• Documentation
• Tests
• ICLA (required for bigger changes)

[codecov-io]

Codecov Report

Merging #1144 into trunk will increase coverage by 0.63%.
The diff coverage is 91.04%.

@@            Coverage Diff             @@
##            trunk    #1144      +/-   ##
==========================================
+ Coverage   85.49%   86.12%   +0.63%     
==========================================
  Files         348      348              
  Lines       66579    66956     +377     
  Branches     5925     5947      +22     
==========================================
+ Hits        56924    57669     +745     
+ Misses       7247     6857     -390     
- Partials     2408     2430      +22

Impacted Files	Coverage Δ
libcloud/test/compute/test_gce.py	97.68% <100%> (+0.08%)	⬆️
libcloud/compute/drivers/gce.py	76.59% <79.31%> (+0.43%)	⬆️
libcloud/storage/base.py	82.8% <0%> (-5.1%)	⬇️
libcloud/__init__.py	71.42% <0%> (-3.58%)	⬇️
libcloud/test/test_init.py	61.53% <0%> (-2.47%)	⬇️
libcloud/test/compute/test_upcloud.py	90.06% <0%> (-2.14%)	⬇️
libcloud/common/cloudstack.py	86.59% <0%> (-1.83%)	⬇️
libcloud/test/common/test_openstack_identity.py	97.94% <0%> (-0.62%)	⬇️
libcloud/test/compute/test_deployment.py	94.7% <0%> (-0.2%)	⬇️
libcloud/test/__init__.py	86.2% <0%> (-0.12%)	⬇️
... and 29 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dcb0cef...ca5898a. Read the comment docs.

[pquentin]

Thank you for your contribution!

Unfortunately the test coverage of libcloud/compute/drivers/gce.py is getting lower with the change, but we want it to be higher, so that your changes keep working in the future. As you know, this is important as this is not something that is easy to test in real conditions. See https://codecov.io/gh/apache/libcloud/pull/1144/src/libcloud/compute/drivers/gce.py#L3198 for an example of bad coverage. Thanks.

[maxlip]

I think these are Travis or other issues - I didn't touch what's failing. But I added tests!

[pquentin]

@maxlip Thanks. However you do have lint errors:

libcloud/test/compute/test_gce.py:847:29: E126 continuation line over-indented for hanging indent
libcloud/test/compute/test_gce.py:864:29: E126 continuation line over-indented for hanging indent
libcloud/test/compute/test_gce.py:881:30: E126 continuation line over-indented for hanging indent 

Rebasing on top of trunk would solve the paramiko issue and would allow me to see the coverage easily. Do you think you could do that? Thanks!

[pquentin]

Sorry, I realized that the paramiko failure is not your fault. You only have the lint to fix. Thanks.

[maxlip]

Just making sure it's clear that linting looks fixed - CI is now all good.
Thanks for your patience with my misreading of CI output :) I can't ever seem to get this tox suite to work on my local, so it can be a challenge.

[pquentin]

There's an extra F here. I'll remove it.

[pquentin]

Thank you @maxlip! Merged in trunk! ✨

I've credited you as "maxlip". Would you like me to use something else?

[maxlip]

Thanks for fixing that Quentin - "maxlip" is good for me.