Enable to specify project id in OpenStack OIDC auth #1293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## trunk #1293 +/- ##
==========================================
+ Coverage 85.95% 85.95% +<.01%
==========================================
Files 359 359
Lines 73911 73916 +5
Branches 6705 6708 +3
==========================================
+ Hits 63530 63535 +5
+ Misses 7699 7698 -1
- Partials 2682 2683 +1
Continue to review full report at Codecov.
|
|
Thanks for the contribution. Can you please also open a PR with a corresponding documentation change (ideally with a code example on how to specify a project)? |
Kami
reviewed
Jun 22, 2019
| return (httplib.OK, body, self.json_content_headers, httplib.responses[httplib.OK]) | ||
| raise NotImplementedError() | ||
|
|
||
| def _v3_auth_projects(self, method, url, body, headers): | ||
| if method == 'GET': | ||
| # get user projects | ||
| body = json.dumps({"projects": [{"id": "project_id"}]}) | ||
| body = json.dumps({"projects": [{"id": "project_id", "name": "project_name"}, |
There was a problem hiding this comment.
It would also be good to add a test case for scenario where invalid project id is specified.
asfgit
pushed a commit
that referenced
this pull request
Jun 22, 2019
|
I went ahead and merged it into trunk, but I would appreciate if you can open a new PR with corresponding documentation and tests change. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable to specify project id in OpenStack OIDC auth
Description
In current implementation the OpenStack OIDC auth the first project available is selected.
This PR enables to specify the project id using the domain_name (as the tenant_name attribute is used to specify the protocol). The domain_name attribute can be used either to select the domain name in case of domain scoped token or to select the project name in case of project scoped token
Status
Checklist (tick everything that applies)