Maxihost provider #1298
Maxihost provider #1298
Conversation
Codecov Report
@@ Coverage Diff @@
## trunk #1298 +/- ##
==========================================
- Coverage 85.95% 85.95% -0.01%
==========================================
Files 359 362 +3
Lines 73914 74090 +176
Branches 6705 6719 +14
==========================================
+ Hits 63533 63681 +148
- Misses 7699 7722 +23
- Partials 2682 2687 +5
Continue to review full report at Codecov.
|
…d into maxihost-provider
|
Thanks for the contribution 👍 It looks like a good start. Since it's a bigger contribution, can you please also sign an ICLA (http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes)? In addition to that, can you also add some more test cases for various edge cases (invalid credentials, etc.) and corresponding documentation page? |
| attr = {'hostname': name, 'plan': size.id, | ||
| 'operating_system': image.id, | ||
| 'facility': location.id.lower(), 'billing_cycle': 'monthly', | ||
| 'ex_ssh_key_ids': ex_ssh_key_ids} |
There was a problem hiding this comment.
Looking at the docs (https://developers.maxihost.com/reference#post_devices), the attribute name on the API side should be ssh_keys, right?
| driver=self, extra=extra) | ||
| return node | ||
|
|
||
| def list_locations(self, available=True): |
| data = self.connection.request('/account/keys') | ||
| return list(map(self._to_key_pair, data.object['ssh_keys'])) | ||
|
|
||
| def create_key_pair(self, name, public_key=''): |
There was a problem hiding this comment.
Should remove default argument value if the argument is required (aka (self, name, public_key)).
|
Thanks for adding the docs, etc. There are some more small issues left which I will address when merging this into master. |
|
@Kami thanks for addressing the issues |
Implementation for connection and main actions for Maxihost provider
Description
Implemented main classes and methods for connecting with Maxihost's API. API ref can be found: https://developers.maxihost.com
Status
Checklist (tick everything that applies)