Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing "cpuPlatform" field to GCE driver #1342

Closed
yairshemla opened this issue Aug 19, 2019 · 3 comments
Closed

Add missing "cpuPlatform" field to GCE driver #1342

yairshemla opened this issue Aug 19, 2019 · 3 comments

Comments

@yairshemla
Copy link
Contributor

yairshemla commented Aug 19, 2019 •
edited

Add "cpuPlatform" and "minCpuPlatform" to GCE driver.
This field is already being fetched by libcloud, but gets discarded during the _to_node method.

on file compute/drivers/gce.py, line 8852 add:
extra['cpuPlatform'] = node.get('cpuPlatform')
extra['minCpuPlatform'] = node.get('minCpuPlatform')
@yairshemla yairshemla changed the title Add "cpuPlatform" field to GCE driver Add missing "cpuPlatform" field to GCE driver Aug 19, 2019
@Kami
Copy link
Member

Kami commented Aug 19, 2019

@yairshemla Please feel free to open a pull request with this change - we are happy to merge it.

@yairshemla
Copy link
Contributor Author

@Kami Hi, sure. here's the PR:
#1343

@Kami
Copy link
Member

Kami commented Aug 28, 2019

Resolved via #1343.

@Kami Kami closed this as completed Aug 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Kami @yairshemla