Fix Azure compute driver to allow adding maximum number of disks when LUN is unspecified #1372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## trunk #1372 +/- ##
==========================================
+ Coverage 86.34% 86.34% +<.01%
==========================================
Files 372 372
Lines 76190 76198 +8
Branches 6974 6975 +1
==========================================
+ Hits 65784 65792 +8
Misses 7609 7609
Partials 2797 2797
Continue to review full report at Codecov.
|
|
Thanks for the contribution. LGTM, but it would also be good to add a test case for this change. /cc @c-w |
… LUN is unspecified
|
@Kami I have extended |
|
Merged. Thanks for the contribution 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Azure compute driver to allow adding maximum number of disks when LUN is unspecified
Description
When the LUN is unspecified in the
attach_volumemethod, it finds the lowest available number to attach the volume to. The maximum number of data disks on an Azure VM is 64, which means LUNs can range from 0 to 63.The current logic to figure out the LUN iterates from 0 to 62:
for lun in range(0, 63). When you try to add the Nth device where N = maximum number of data disks allowed for that instance size, this code raisesLibcloudError("No LUN available to attach new disk.").This PR fixes this to ensure the last LUN is usable.
Status
Checklist (tick everything that applies)