Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for eu-north-1 in ec2 #1486

Merged
merged 3 commits into from Sep 22, 2020
Merged

Add support for eu-north-1 in ec2 #1486

merged 3 commits into from Sep 22, 2020

Conversation

r2ronoha
Copy link
Contributor

@r2ronoha r2ronoha commented Sep 9, 2020

Add support for eu-north-1 in ec2

Description

Add region eu-north-1 to the list of supported ec2 regions, with the list of instances for which a price is configured in pricing.json

Status

  • done, ready for review

Checklist (tick everything that applies)

  • Code linting (required, can be done after the PR checks)
  • Documentation
  • Tests
  • ICLA (required for bigger changes)

@@ -9184,6 +9184,174 @@
],
"signature_version": "4"
},
"eu-north-1": {
"api_name": "ec2_eu_north",
"country": "Stockholm",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

country is Sweden

Copy link
Member

@Kami Kami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution.

Change look good to me - I just hope you used tox target to re-generate that file (tox -e scrape-ec2-sizes) and didn't update it manually since that would be quite painful :)

@Kami
Copy link
Member

Kami commented Sep 22, 2020

On that note ^ - I also updated that tox target to print a warning message - pricing data we download (if it's not already cached locally) is over 1 GB in size which means running that tox target may take up to 10 minutes or more.

I also ran that tox target with the latest pricing file - 0e9aefc.

@asfgit asfgit merged commit 6624946 into apache:trunk Sep 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants