dns/digitalocean: send attributes in body for PUT and POST operations. #1505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## trunk #1505 +/- ##
==========================================
- Coverage 84.77% 84.77% -0.01%
==========================================
Files 388 388
Lines 81521 81521
Branches 8243 8243
==========================================
- Hits 69111 69109 -2
- Misses 9422 9423 +1
- Partials 2988 2989 +1
Continue to review full report at Codecov.
|
|
Thanks for the contribution. The changes look good to me, but it would be good to add some tests for it (should be pretty straight forward - just need to update mock http classes to assert on the request body). |
andrewsomething
force-pushed
the
do-dns-query-params
branch
from
ee5c1f7
to
11529ee
Compare
andrewsomething
force-pushed
the
do-dns-query-params
branch
from
11529ee
to
8837ee7
Compare
|
Good call. Changed tests fail on trunk and pass against this branch. |
|
Thanks for adding the tests. I've added a small change (9b72e75) and merged changes into trunk. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dns/digitalocean: send attributes in body for PUT and POST operations.
Description
Like with the DigitalOcean compute driver, requests for the DNS driver should send data in the body for PUT and POST operations rather than in query parameters. e.g. https://developers.digitalocean.com/documentation/v2/#create-a-new-domain-record
Status
Checklist (tick everything that applies)