Fix a bug with edge-case in get_object() method in Google Storage Driver #1547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some situations, Google Storage wuld return object size in x-goog-stored-content-length header and not content-length one and our code didn't correctly handle that scenario. As part of this change, I also updated the code to correctly cast object.size attribute to int when using "get_object" method. Thanks to @RunOrVeith for reporting this issue.
|
I'll go ahead and merge this since I hope to start voting thread for a bug fix release today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes issue reported in #1544.
Background, Context
In some scenarios, Google Storage S3 compatible API returns object size in
x-goog-stored-content-lengthheader of incontent-lengthone.Before this change, our code didn't correctly handle this case. updated the code so
object.sizeattribute populated inget_object()is an integer and not a string - this way it's consistent withlist_objects()method.As part of this PR, I also
Thanks
Thanks to @RunOrVeith for reporting this issue.