Equinix update #1548
Merged
Equinix update #1548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## trunk #1548 +/- ##
==========================================
- Coverage 83.08% 83.08% -0.01%
==========================================
Files 394 394
Lines 84795 84808 +13
Branches 9004 9006 +2
==========================================
+ Hits 70456 70460 +4
- Misses 11274 11282 +8
- Partials 3065 3066 +1
Continue to review full report at Codecov.
|
dimgal1
force-pushed
the
equinix-update
branch
from
d85509a
to
93cf485
Compare
Kami
reviewed
Feb 12, 2021
| disk = None | ||
| if data['specs'].get('drives', ''): | ||
| disk = 0 | ||
| for disks in data['specs']['drives']: |
There was a problem hiding this comment.
Eventually it would be nice to split this formatting functionality in separate functions to make (unit) testing easier, but not a blocker for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various updates on EquinixMetal compute driver
Description
Handle exceptions where necessary, pass explicitly
diskanddisk_sizeinstead of kwargs on create_node, addsupported_sizesfield on images andregionsfield on sizes.Status
Checklist (tick everything that applies)