Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support volume v3 API endpoint in OpenStack driver #1561

Merged
merged 3 commits into from Mar 15, 2021

Conversation

micafer
Copy link
Contributor

@micafer micafer commented Mar 3, 2021

Support volume v3 API endpoint in OpenStack driver

Implements: #1560

Description

This solution tries to find if the cinderv3 endpoint is available and in this case the volume related functions will use that endpoint, otherwise it will user the cinderv2 one.

Status

  • done, ready for review

Checklist (tick everything that applies)

  • Code linting (required, can be done after the PR checks)
  • Documentation
  • Tests
  • ICLA (required for bigger changes)

Copy link
Member

@Kami Kami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add a changelog entry?

Besides that, LGTM 👍

@micafer micafer merged commit cc5987b into apache:trunk Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants