Support updating allowed_address_pairs on OpenStack ports

[dpeschman]

Support updating allowed_address_pairs on OpenStack ports

Description

Add support to OpenStack_2_NodeDriver for updating allowed-address-pairs on node ports. This is a security extension that allows administrators to specify which IP and MAC addresses a node can use to communicate.

https://docs.openstack.org/api-ref/network/v2/index.html#allowed-address-pairs

Status

• done, ready for review

Checklist (tick everything that applies)

• Code linting (required, can be done after the PR checks)
• Documentation
• Tests
• ICLA (required for bigger changes)

[codecov-io]

Codecov Report

Merging #1569 (5786481) into trunk (174f409) will decrease coverage by 0.08%.
The diff coverage is 85.71%.

@@            Coverage Diff             @@
##            trunk    #1569      +/-   ##
==========================================
- Coverage   83.08%   83.00%   -0.09%     
==========================================
  Files         394      394              
  Lines       84795    84950     +155     
  Branches     9004     9037      +33     
==========================================
+ Hits        70456    70516      +60     
- Misses      11274    11369      +95     
  Partials     3065     3065              

Impacted Files	Coverage Δ
libcloud/compute/drivers/openstack.py	85.84% <50.00%> (+0.10%)	⬆️
libcloud/test/compute/test_openstack.py	94.45% <100.00%> (+0.01%)	⬆️
libcloud/compute/drivers/equinixmetal.py	64.28% <0.00%> (-0.98%)	⬇️
libcloud/compute/drivers/outscale.py	8.66% <0.00%> (-0.02%)	⬇️
libcloud/common/base.py	90.59% <0.00%> (+0.02%)	⬆️
libcloud/test/compute/test_ovh.py	97.34% <0.00%> (+0.02%)	⬆️
libcloud/test/storage/test_azure_blobs.py	94.89% <0.00%> (+0.21%)	⬆️
libcloud/storage/drivers/azure_blobs.py	86.84% <0.00%> (+0.60%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 174f409...5786481. Read the comment docs.

[Kami]

LGTM, thanks for contribution.

@micafer can you please also review this change?

[micafer]

LGTM, thanks for contribution.

@micafer can you please also review this change?

It LGTM also.

[dpeschman]

I'm tempted to also add methods to add and remove a single address-pair. Would you be interested in this?

[Kami]

@dpeschman Yeah, that seems reasonable for - just please prefix those methods with ex_ since they are not part of the common / standard API.

[Kami]

I merged change into trunk - thanks for the contribution.

Please feel free to open a new PR for those two new additional methods.