Fix NSOne DNS Provider #1571
Fix NSOne DNS Provider #1571
Conversation
|
Thanks for the contribution and sorry for the delay. The change looks good to me, but it would be great if you could add corresponding unit tests. |
libcloud/dns/drivers/nsone.py
Outdated
| @@ -206,7 +206,7 @@ def delete_record(self, record): | |||
|
|
|||
| return response.status == httplib.OK | |||
|
|
|||
| def create_record(self, name, zone, type, data, extra=None): | |||
| def create_record(self, name, zone, type_, data, extra=None): | |||
There was a problem hiding this comment.
type argument is part of the standard API (aka is the same for all the provider drivers) so we should use it here as well.
I know it's not ideal since it clashes with a built-int value, but not much we can do at this point (besides changing the standard API + updating all the drivers in the future).
There was a problem hiding this comment.
Besides that, changes look good to me - please just add some tests when you get a chance.
karantan
force-pushed
the
fix/nsone-create-record
branch
from
ce33fbe
to
45c5d20
Compare
|
hey, sorry for the delay. I was busy with other things ... anyway I added 3 tests and renamed |
- handle mx records - handle root domain
karantan
force-pushed
the
fix/nsone-create-record
branch
from
45c5d20
to
754f2b4
Compare
|
@Kami gentle ping |
Fix NSOne DNS Provider
Description
Status
Checklist (tick everything that applies)