Fix crash on missing etag in s3 storage driver #1683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for reporting and fixing this issue. Do you happen to know how it affects object uploads? Since, IIRC, we use e-tag returned on upload to verify that checksum matches and that there was no corruption on upload. Or this only affects get requests? EDIT: I had a better look and it indeed appears it only affects GET object requests so it should be fine (only the |
Kami
approved these changes
May 6, 2022
|
Merged into trunk, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix broken blob access
Description
Replaces the required access to the
etagkey with optional access.I am not sure what implications this has on other components, but you can at least read public blobs again.
This fixes #1682
Status
Checklist (tick everything that applies)