Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the new US based locations. #1781

Merged

Conversation

mohsen-hassani-cs
Copy link
Contributor

@mohsen-hassani-cs mohsen-hassani-cs commented Oct 10, 2022

New US location URLs related to CloudSigma are updated.

Description

The new locations are wdc.alpha3cloud.com and sjc.alpha3cloud.com

@Kami
Copy link
Member

Kami commented Oct 15, 2022

Thanks for the contribution. The change looks good to me, but it would be good to also add / update test cases.

Having said that - should this driver also be renamed from CloudSigma to Alpha2Cloud? Or should the driver name be left as is and we perhaps add an alias for Alpha2Cloud -> Cloud Sigma (or vice versa).

@codecov-commenter
Copy link

Codecov Report

Merging #1781 (3ccff87) into trunk (a4f4f90) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##            trunk    #1781   +/-   ##
=======================================
  Coverage   83.41%   83.41%           
=======================================
  Files         394      394           
  Lines       87680    87680           
  Branches     9261     9261           
=======================================
  Hits        73135    73135           
  Misses      11386    11386           
  Partials     3159     3159           
Impacted Files Coverage Δ
libcloud/common/cloudsigma.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4f4f90...3ccff87. Read the comment docs.

@mohsen-hassani-cs
Copy link
Contributor Author

Thanks @Kami

The driver should not be renamed. It should be left as CloudSigma.
We have just changed the URLs for two locations but the driver and the functionality should be the same.

@Kami
Copy link
Member

Kami commented Dec 5, 2022

@mohsen-hassani-cs Thanks for confirming and sorry for the delay (I've missed your comment). I will go ahead and merge you PR.

Thanks again for your contribution.

asfgit pushed a commit that referenced this pull request Dec 5, 2022
@asfgit asfgit merged commit 1291084 into apache:trunk Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants