Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for af south 1 in s3 driver #1821

Merged

Conversation

alier350
Copy link
Contributor

Add support for AWS af-south-1 region to S3 storage driver

Description

We noticed the following error when running our Ansible automation on af-south-1 VMs on AWS:

File "/usr/local/lib/python3.8/dist-packages/libcloud/storage/drivers/s3.py", line 1134, in __init__
        raise ValueError('Invalid or unsupported region: %s' % (region))
    ValueError: Invalid or unsupported region: af-south-1

The reason for the error is missing configuration for the af-south-1 region of AWS in the S3 driver of libcloud, which we have remediated locally and now raising this PR to contribute back to the project.

Status

  • done, ready for review (Used pylint for linting)

Checklist (tick everything that applies)

  • Code linting (required, can be done after the PR checks)
  • Documentation
  • Tests
  • ICLA (required for bigger changes)

@Kami
Copy link
Member

Kami commented Jan 2, 2023

Thank you for the contribution.

Only change needed is updating REGION_TO_HOST_MAP dictionary. Adding new classes is not needed anymore - this was old and now deprecated approach.

I will remove this new class and merge changes into trunk.

asfgit pushed a commit that referenced this pull request Jan 2, 2023
@asfgit asfgit merged commit 31417cf into apache:trunk Jan 2, 2023
@Kami
Copy link
Member

Kami commented Jan 2, 2023

Merged, thanks!

@alier350
Copy link
Contributor Author

alier350 commented Jan 9, 2023

Merged, thanks!

Great stuff, thanks!

@alier350 alier350 deleted the add-support-for-af-south-1-in-s3-driver branch January 9, 2023 09:06
@Kami Kami added this to the v3.7.0 milestone Jan 28, 2023
@Kami Kami mentioned this pull request Sep 13, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants