BaseEC2NodeDriver.ex_register_image: support additional parameters #1906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for more EC2 RegisterImage parameters: - boot_mode: control bios vs. uefi boot. - tpm_support: enable a tpm. - uefi_data: provide NV UEFI vars. - imds_support: require IMDSv2.
Kami
approved these changes
Aug 1, 2023
asfgit
pushed a commit
that referenced
this pull request
Aug 1, 2023
|
Merged into trunk. Thanks. |
asfgit
pushed a commit
that referenced
this pull request
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for more EC2 RegisterImage parameters:
I haven't added tests, as these are just passed through. The parameter names are taken from the ec2 api doc.
I have tested it by creating an image that sets
BootModeto a non-default value.Status
done, ready for review
Checklist (tick everything that applies)