Digitalocean ex_rename_node() extension method #252
Conversation
|
This looks like a good start. There are some lint and test failure issues though - https://travis-ci.org/apache/libcloud/builds/19144330 For tests to pass you need to fix the method call, add a response fixture and modify the MockHttpClass to return your response fixture on rename node HTTP request. |
| @@ -127,6 +127,12 @@ def destroy_node(self, node): | |||
| params=params) | |||
| return res.status == httplib.OK | |||
|
|
|||
| def ex_rename(self, node, name): | |||
There was a problem hiding this comment.
Please add _node suffix to the method name to make it clear that the method operates on a node.
|
@Kami Thanks I will make the changes :) |
|
@Kami done 👍 |
|
@rahulrrixe Looking good. Please just squash all the commits (https://libcloud.readthedocs.org/en/latest/development.html#squash-the-commits-and-generate-the-patch) and I will merge changes into trunk. |
added test suite for the ex_rename() extention method changed ex_rename() to ex_rename_node() extention method Added the MockHttptestcase from ex_rename_node() extension method changed ex_rename() to ex_rename_node() extention method corrected the MockHttptestcase for ex_rename_node() method Added a fixture for ex_rename_node() method
|
Merged into trunk, thanks. This pull request can be closed now. |
|
@Kami Thanks 👍 looking forward for next task. |
@Kami as you have told me; I have added the extension method for renaming digitalocean node and also test suit for it.