[google compute] Adding GCE DiskTypes resource - part 1 #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erjohnso
force-pushed
the
GCE_DiskTypes
branch
from
9574556
to
247491c
Compare
erjohnso
force-pushed
the
GCE_DiskTypes
branch
from
247491c
to
e549821
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding GCE DiskTypes[1] support - part 1.
The GCE driver fakes support for DiskTypes at the moment and relies on a string
pd-ssdorpd-standardfor users to select the disktype. This PR sets the ground work to add GCE native DiskTypes that will be easier to expand in the future. For instance, Google has already introduced alocal-ssdoption.I opted to split this up into two PRs so that this one only introduces a new libcloud object and does not tinker with existing "fake" disk-types. Part 2 will be a follow-up to this one to update existing use of the string-version option and also allow using the new GCEDiskType object.
[1] https://cloud.google.com/compute/docs/reference/latest/diskTypes