[google compute] improved Images coverage #395
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if not image: | ||
| if (partial_name.startswith('debian') or | ||
| partial_name.startswith('backports')): | ||
| partial_name.startswith('backports') or | ||
| partial_name.startswith('nvme-backports')): |
erjohnso
added a commit
that referenced
this pull request
Nov 23, 2014
Signed-off-by: Sebastien Goasguen <runseb@gmail.com> This closes #395
erjohnso
added a commit
to erjohnso/libcloud
that referenced
this pull request
Dec 1, 2014
Signed-off-by: Sebastien Goasguen <runseb@gmail.com> This closes apache#395
| @@ -2218,6 +2246,27 @@ def ex_deprecate_image(self, image, replacement, state=None): | |||
| 'replacement': replacement.extra['selfLink'], | |||
| } | |||
|
|
|||
| if deprecated is not None: | |||
There was a problem hiding this comment.
Sorry for a late comment. Number of duplicated lines of code could be reduced by doing something like that:
for attribute, value in [('deprecated', deprecated), ...]:
is value is None:
continue
try:
timestamp_to_datetime(value)
except:
raise ValueError('deprecated must be an RFC3339 timestamp')
image_data[name] = valueAnyway, that's just a suggestion and not a priority :)
There was a problem hiding this comment.
I like it! Adding it to the next PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to improve the
GCENodeImagecoverage of the GCE API. Specifically, this update has:diskSizeGb,sourceType, etc)preferredKernel. This has long been removed from the GCE API, but there is a chance very old customer images still retain this value.DELETED,OBSOLETE, andDEPRECATED.No breaking changes introduced and tests have been enhanced for these changes.